Toggle 'complete track name' display on double click in otioview #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssteinbach
reviewed
May 18, 2020
| track_name = track_name[:7] + '...' | ||
| self.source_name_label.setText(track_name + '\n({})'.format(track.kind)) | ||
| self.track = track | ||
| self.track_name = 'Track' if track.name == '' else track.name |
There was a problem hiding this comment.
Suggested change
| self.track_name = 'Track' if track.name == '' else track.name | |
| self.track_name = 'Track' if not track.name else track.name |
Should be the same but also covers the case where track.name is None
| self.track = track | ||
| self.track_name = 'Track' if track.name == '' else track.name | ||
| self.full_track_name = self.track_name | ||
| if len(self.track_name) > 7: |
There was a problem hiding this comment.
lets break the 7 out to be a top level constant, maybe SHORT_NAME_LENGTH
Codecov Report
@@ Coverage Diff @@
## master #690 +/- ##
==========================================
+ Coverage 81.70% 81.72% +0.02%
==========================================
Files 72 72
Lines 2728 2731 +3
==========================================
+ Hits 2229 2232 +3
Misses 499 499
Continue to review full report at Codecov.
|
ssteinbach
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ssteinbach as per your suggestion to have an option to view long track names in otioview, I've added an option to do that on double-clicking on the TrackName widget.
This is how it looks: