-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add windows and mac builds to ci #873
Merged
ssteinbach
merged 23 commits into
AcademySoftwareFoundation:master
from
ssteinbach:more_os_ci
Feb 23, 2021
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
e551029
add windows and mac builds to ci
ssteinbach 29686e3
fall back to mac 10.15
ssteinbach 1a839ea
split lcov target out from the ci-postbuild target
ssteinbach b0e560d
Specify which build does C++ coverage w/ lcov
ssteinbach b36754f
use == syntax instead of contains
ssteinbach dd74941
move the env config out to the top level
ssteinbach 0468291
Skip autogen tests on windows (slashes)
ssteinbach df626f8
sanitize paths when writing autogen docs
ssteinbach 7247c1e
try escaping the slash in the replacement
ssteinbach e91e65e
manifest paths need same treatment
ssteinbach 8cd7001
switch to tempfile.TemporaryDirectory
ssteinbach 644ec3e
another conversion to TemporaryDirectory
ssteinbach 2c0714f
more tempfile cleanup
ssteinbach 072a5c0
whoops missed import
ssteinbach bc0b554
testing if this is specific to the generators xml
ssteinbach 29c8012
only remove windows slashes from sanitized paths
ssteinbach dfc66bd
only run windows ci while I iterate
ssteinbach eeb94fb
run the broken test
ssteinbach e2a6ea0
remove BOM from example xml file
ssteinbach 85c958c
replace more unit test tempfile handling to be more windows compatible
ssteinbach bc66af1
only run XGES unit tests on linux
ssteinbach 6ebee23
turning MacOS and Linux builds back on.
ssteinbach 215de62
Also disable xges for python < 3.
ssteinbach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a shame the BOM doesn't show in the diff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah! oddly enough
git diff
from the command line did show it to me