-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a --version flag to otiopluginfo + otioconvert #880
add a --version flag to otiopluginfo + otioconvert #880
Conversation
1a326bf
to
9f7b7b3
Compare
9f7b7b3
to
d919575
Compare
Codecov Report
@@ Coverage Diff @@
## master #880 +/- ##
=======================================
Coverage 84.36% 84.36%
=======================================
Files 74 74
Lines 3090 3090
=======================================
Hits 2607 2607
Misses 483 483
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one behavior question to make sure there isn't a missing exit, otherwise looks good!
for plugin in pkg_resource_plugins: | ||
print(" {}".format(plugin.dist)) | ||
else: | ||
print("No pkg_resource plugins installed.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the intent to not exit after printing version info and continue printing the usual info?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. The thought was that this program is just dumping information about the installation anyway, so --version
is an additive option and doesn't prevent printing everything else. Happy to change that if you think its too much of a break from expected behavior though.
Adds a
--version
flag tootiopluginfo
andotioconvert
. This:__version__
stringpkg_resource
installed plugins, and prints out their dist info (which includes their version numbers)Question for the community: After seeing this I kind of wish there was a way to also burn the git commit hash into the repo some how. Not sure if thats useful, but it something we could potentially do when we burn the version numbers in.
Output looks like this: