Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --prefix correctly in new cmake system #886

Merged
merged 5 commits into from
Feb 17, 2021
Merged

Support --prefix correctly in new cmake system #886

merged 5 commits into from
Feb 17, 2021

Commits on Feb 15, 2021

  1. Detect prefix by looking in distutils.dist 

    - as far as our googling can tell, this was the only way we could find
  to get the value of the --prefix commandline argument supplied to
  setup.py.
    @ssteinbach
    ssteinbach committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    fcceb06 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. checkpoint

    @ssteinbach
    ssteinbach committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    67661de View commit details
    Browse the repository at this point in the history

  2. fix python installs work w/ --prefix or --user 

    - needed to change how paths get sent into the cmake part of the build
- also moves the cxx-lib directory to be called cxx-sdk
    @ssteinbach
    ssteinbach committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    9895b81 View commit details
    Browse the repository at this point in the history

  3. apply same logic for determining cxx-sdk 

    - use the same logic for where the cxx-sdk location regardless of which
  branch through the setup.py is taken
    @ssteinbach
    ssteinbach committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    eed50c9 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. found a few more cxx-libs -> cxx-sdk

    @ssteinbach
    ssteinbach committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    941d3ac View commit details
    Browse the repository at this point in the history