validate filesize before allocating chunk memory #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Hillman <[email protected]>
kdt3rd
reviewed
Sep 28, 2021
| @@ -70,6 +70,17 @@ extract_chunk_table ( | |||
| return ctxt->report_error ( | |||
| ctxt, EXR_ERR_INVALID_ARGUMENT, "Invalid file with no chunks"); | |||
|
|
|||
| if (chunkbytes + chunkoff > (uint64_t) ctxt->file_size) | |||
There was a problem hiding this comment.
fyi, can't remember but I do allow a stream implementation to return -1 if they do not know the file size, which should then return false and succeed for this, but just thought I'd mention it so you know - I have been a bit pedantic about checking that elsewhere, although the math here is pretty simple...
kdt3rd
approved these changes
Sep 28, 2021
|
Sorry to report this, but last night's OIIO "bleeding edge" CI test that uses openexr master has a number of "EXR Error (attrib2.exr): EXR_ERR_INVALID_ARGUMENT chunk table size (32) too big for file size (0)" for exr files that I'm sure are fine and that I've been using for tests forever. |
|
OK, I'll do the thing that @kdt3rd said to do. New PR coming. |
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Oct 14, 2021
…dation#1161) Signed-off-by: Peter Hillman <[email protected]>
cary-ilm
pushed a commit
that referenced
this pull request
Oct 24, 2021
Signed-off-by: Peter Hillman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=39332
Prevent excessive memory allocation by ensuring file is large enough to contain chunk table before allocating memory
Signed-off-by: Peter Hillman [email protected]