Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub action for release notices on Slack #1601

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

cary-ilm
Copy link
Member

No description provided.

@cary-ilm
Copy link
Member Author

cary-ilm commented Jan 3, 2024

@jmertic, @lgritz, @JeanChristopheMorinPerso, does this look right to you? Is there anything else to configure to handle authentication?

@lgritz
Copy link
Contributor

lgritz commented Jan 3, 2024

The secrets.SLACK_BOT_TOKEN already there will handle the authentication.

Looks right to me? Hard to know 100% until we do a release and see if it shows up. But even getting in wrong is really low risk, the worst case is probably that we don't get the announcement.

project_name: "OpenEXR"
slack_bot_token: ${{ secrets.SLACK_BOT_TOKEN }}
slack_channel: "#release-announcements"
project_logo: "https://artwork.aswf.io/other/aswf/text/aqua/aswf-text-aqua.png"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could change this to the logo for OpenEXR instead. It's best if it can be a square image, which the Icon only is pretty close to...

https://artwork.aswf.io/projects/openexr/icon/color/openexr-icon-color.png

project_name: "OpenEXR"
slack_bot_token: ${{ secrets.SLACK_BOT_TOKEN }}
slack_channel: "#openexr"
project_logo: "https://artwork.aswf.io/other/aswf/text/aqua/aswf-text-aqua.png"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

@jmertic
Copy link
Contributor

jmertic commented Jan 4, 2024

Overall, it looks good - made one comment on the image so it shows up with OpenEXR branding. Let's see how it works once a release happens :)

Signed-off-by: Cary Phillips <[email protected]>
@cary-ilm cary-ilm merged commit bafa35e into AcademySoftwareFoundation:main Jan 22, 2024
29 checks passed
cary-ilm added a commit to cary-ilm/Imath that referenced this pull request Jan 27, 2024
cary-ilm added a commit to AcademySoftwareFoundation/Imath that referenced this pull request Jan 27, 2024
cary-ilm added a commit to AcademySoftwareFoundation/Imath that referenced this pull request Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants