-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub action for release notices on Slack #1601
GitHub action for release notices on Slack #1601
Conversation
Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
@jmertic, @lgritz, @JeanChristopheMorinPerso, does this look right to you? Is there anything else to configure to handle authentication? |
The Looks right to me? Hard to know 100% until we do a release and see if it shows up. But even getting in wrong is really low risk, the worst case is probably that we don't get the announcement. |
.github/workflows/release-notice.yml
Outdated
project_name: "OpenEXR" | ||
slack_bot_token: ${{ secrets.SLACK_BOT_TOKEN }} | ||
slack_channel: "#release-announcements" | ||
project_logo: "https://artwork.aswf.io/other/aswf/text/aqua/aswf-text-aqua.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could change this to the logo for OpenEXR instead. It's best if it can be a square image, which the Icon only is pretty close to...
https://artwork.aswf.io/projects/openexr/icon/color/openexr-icon-color.png
project_name: "OpenEXR" | ||
slack_bot_token: ${{ secrets.SLACK_BOT_TOKEN }} | ||
slack_channel: "#openexr" | ||
project_logo: "https://artwork.aswf.io/other/aswf/text/aqua/aswf-text-aqua.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above
Overall, it looks good - made one comment on the image so it shows up with OpenEXR branding. Let's see how it works once a release happens :) |
Signed-off-by: Cary Phillips <[email protected]>
Similar to OpenEXR (AcademySoftwareFoundation/openexr#1601) Signed-off-by: Cary Phillips <[email protected]>
Similar to OpenEXR (AcademySoftwareFoundation/openexr#1601) Signed-off-by: Cary Phillips <[email protected]>
Similar to OpenEXR (AcademySoftwareFoundation/openexr#1601) Signed-off-by: Cary Phillips <[email protected]>
No description provided.