Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uninstall target #1624

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Commits on Feb 1, 2024

  1. Add uninstall target

    Satisfy the OpenSSF Best Practices Badge requirement for an
    insta/uninstall process:
    https://www.bestpractices.dev/en/criteria/1#1.installation_common
    
    CMake does not support a standard "uninstall" target, but the
    community recommends implementing an "uninstal" target that remove files named in the
    `install_manifest.txt`:
    https://gitlab.kitware.com/cmake/community/-/wikis/FAQ#can-i-do-make-uninstall-with-cmake
    
    However, our existing process of installing the symlink to the "bare"
    library, i.e. the symlink from libImath-3_2.so to libImath.so, fails
    to add the symlink to the manifest, so "make uninstall" misses the
    symlink. The existing mechanism use "install(CODE execute_process(cmake -E create_symlink))".
    
    This changes that to use a simpler "file(CREATE_LINK)" and
    "install(FILES)" to accomplish the same thing while also registering
    the symlink the the manifest.
    
    Also, this fixes an issue where `OpenEXRConfig.h` was passed to
    `install()` twice, producing two entries in `install_manifest.txt`.
    
    Signed-off-by: Cary Phillips <[email protected]>
    cary-ilm committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    81cecbd View commit details
    Browse the repository at this point in the history
  2. mention uninstall in install instructions

    Signed-off-by: Cary Phillips <[email protected]>
    cary-ilm committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    3e57c10 View commit details
    Browse the repository at this point in the history
  3. poke

    Signed-off-by: Cary Phillips <[email protected]>
    cary-ilm committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    59f6f40 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. COPY_ON_ERROR

    Signed-off-by: Cary Phillips <[email protected]>
    cary-ilm committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    73d64d7 View commit details
    Browse the repository at this point in the history
  2. clarify the uninstall instructions

    Signed-off-by: Cary Phillips <[email protected]>
    cary-ilm committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    50fcd31 View commit details
    Browse the repository at this point in the history