Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt #1690

Closed
wants to merge 1 commit into from

Conversation

aclark4life
Copy link

@aclark4life aclark4life commented Mar 23, 2024

Signed-off-by: Jeffrey A. Clark <[email protected]>
@aclark4life
Copy link
Author

👍

Screenshot 2024-03-22 at 9 53 32 PM

Only problem now is dark styles are incomplete and not sure if auto load is working, I get dark by default now at least. May need to fix this in sphinx-press-theme 0.9.2 particularly if it is a blocker for OEXR deployment.

@cary-ilm
Copy link
Member

Thanks! I do prefer the dark style, glad to see it as an option, and also fine if it's the default. Where are you noticing it's incomplete?

The ASWF logo in the page footers is dark so doesn't read in dark mode. There's a white version at https://artwork.aswf.io/other/aswf/logo/black/aswf-logo-white.svg, can it be configured to choose depending on the mode?
or there's a gold option at https://artwork.aswf.io/other/aswf/logo/gold/aswf-logo-gold.svg which might work in light and dark.

@aclark4life
Copy link
Author

Thanks! I do prefer the dark style, glad to see it as an option, and also fine if it's the default. Where are you noticing it's incomplete?

For example the text on the warning alert needs to be made dark mode specific so that is readable. That's a CSS fix somewhere.

Screenshot 2024-03-25 at 9 52 26 AM

The ASWF logo in the page footers is dark so doesn't read in dark mode. There's a white version at https://artwork.aswf.io/other/aswf/logo/black/aswf-logo-white.svg, can it be configured to choose depending on the mode? or there's a gold option at https://artwork.aswf.io/other/aswf/logo/gold/aswf-logo-gold.svg which might work in light and dark.

I would say that in the short term, if you could merge and change the logo to gold that would be my preference, just to get it out there. However, if there is anything you can't live with in the short term, let me know and I'll try to fix. The rest of proposed changes (CSS fixes, logo configurability, etc) can go in a future release of sphinx-press-theme. 😎

@aclark4life
Copy link
Author

Newer version deployed! Probably don't need this anymore.

@aclark4life aclark4life closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants