Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refined validation checks #1828

Merged

Conversation

kdt3rd
Copy link
Contributor

@kdt3rd kdt3rd commented Sep 19, 2024

allows duplicate parameter names in non-strict mode to match legacy C++ library
bolsters channel checks
fixes issue with not skipping rest of attribute size in channel lists when stopping short

This will address a number of OSS-Fuzz: 71692, 71706, 71707, 71733

Old library allowed names to accumulate, whether that is a great feature
or not, preserve that when not in strict mode.

Signed-off-by: Kimball Thurston <[email protected]>
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdt3rd kdt3rd merged commit 04cc126 into AcademySoftwareFoundation:main Sep 19, 2024
34 checks passed
@kdt3rd kdt3rd deleted the ossfuzz_refined_validation_checks branch September 19, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants