Fix 1255-possible-regression-appendenv-in-powershell-fails-if-env-variable-does-not-exist-already #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1255 |
|
Kudos, SonarCloud Quality Gate passed!
|
instinct-vfx
changed the title
|
What needs to be done to get this merged? |
|
At least two approvals for the TSC members. I already internally requested a review on this. |
|
I would value a comment explaining why the command is set to silently ignore errors. It's one of those things I could see getting removed in the future if no one remembers why it was added. |
instinct-vfx
force-pushed
the
1255-possible-regression-appendenv-in-powershell-fails-if-env-variable-does-not-exist-already
branch
from
681b242
to
4accb0a
Compare
Signed-off-by: Thorsten Kaufmann <[email protected]>
Signed-off-by: Thorsten Kaufmann <[email protected]>
Signed-off-by: Thorsten Kaufmann <[email protected]>
instinct-vfx
force-pushed
the
1255-possible-regression-appendenv-in-powershell-fails-if-env-variable-does-not-exist-already
branch
from
f6d2cf4
to
e3f0020
Compare
JeanChristopheMorinPerso
approved these changes
Oct 17, 2022
…rshell-fails-if-env-variable-does-not-exist-already Signed-off-by: Thorsten Kaufmann <[email protected]>
maxnbk
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a regression that was introduced by #1176
The nested
Get-ChildItemcall fails with an error if the Variable does not exist. Old behaviour restored without reverting the fix by adding-ErrorAction SilentlyContinue