Add REZ_USED_LOCAL_RESOLVE context environment variable #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Populate the environment variable "REZ_USED_LOCAL_RESOLVE" in the same style as REZ_USED_EPH_RESOLVE for any packages resolved to a local destination Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
JeanChristopheMorinPerso
approved these changes
Sep 21, 2022
nerdvegas
previously requested changes
Sep 21, 2022
There was a problem hiding this comment.
I'm ok with what's been done here, but the docs need updating here: https://github.com/AcademySoftwareFoundation/rez/wiki/Environment-Variables#context-environment-variables
Take care to note that this new envvar will contain a subset of what's already in REZ_USED_RESOLVE.
You just need to update this file, the wiki will be updated for you: https://github.com/AcademySoftwareFoundation/rez/blob/master/wiki/pages/Environment-Variables.md
Signed-off-by: Josh <[email protected]>
|
@nerdvegas How's that look? |
|
Thanks for documenting it! To me it looks great. |
JeanChristopheMorinPerso
requested review from
nerdvegas
and removed request for
nerdvegas
maxnbk
approved these changes
Nov 15, 2022
JeanChristopheMorinPerso
dismissed
nerdvegas’s stale review
The requested change was correctly made
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populate the environment variable "REZ_USED_LOCAL_RESOLVE" in the same style as REZ_USED_EPH_RESOLVE for any packages resolved to a local destination
Closes #1371
Let me know if there's a version number I need to bump or something