-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'gbk' codec can't encode character '\u200b' when resolve context #1508
Fix 'gbk' codec can't encode character '\u200b' when resolve context #1508
Conversation
Signed-off-by: loonghao <[email protected]>
…porter.path`, Signed-off-by: loonghao <[email protected]>
Signed-off-by: loonghao <[email protected]>
Signed-off-by: loonghao <[email protected]>
The io.open / codecs switch causes the py2.7 tests to fail, presently. Could that be wrapped per version? Something like?
|
Test failed in CI same with this issues#1502
I see the CI logs: @maxnbk I will update the MR, Thanks. |
Signed-off-by: loonghao <[email protected]>
@maxnbk I have already updated the PR. Please take your time to review it again and let me know if there is anything else that needs to be modified. Thank you. |
Kudos, SonarCloud Quality Gate passed! |
1fd1c58
into
AcademySoftwareFoundation:master
Thank you @loonghao ! We merged your change and it should be released in the next release. |
This PR is try to fix #1507