Fix CI failures with Python 2.7 #1521
Conversation
Signed-off-by: Jean-Christophe Morin <[email protected]>
|
@Jawabiscuit are you of failures on the csh shell tests? You've been running the tests I guess, so maybe you know? |
|
I wouldn't be so quick to throw out csh. Autodesk Flame systems default to it, and I know of environments where rez participates in Flame environments. |
|
@JeanChristopheMorinPerso, csh hasn't posed any problems at all in my testing. |
JeanChristopheMorinPerso
force-pushed
the
fix_py2_ci
branch
6 times, most recently
from
8754e72
to
e6fa49f
Compare
Signed-off-by: Jean-Christophe Morin <[email protected]>
JeanChristopheMorinPerso
force-pushed
the
fix_py2_ci
branch
2 times, most recently
from
d06c263
to
70ce68c
Compare
Signed-off-by: Jean-Christophe Morin <[email protected]>
JeanChristopheMorinPerso
force-pushed
the
fix_py2_ci
branch
from
70ce68c
to
84760d1
Compare
|
Alright, I fixed the csh issue. It wasn't related to the tests. I fixed it by simply not using fancy action to install conda. Conda already comes pre-installed on the runners so we don't need to install it. I think the action was injecting stuff into the job environment which I think was messing up rez in some ways (which isn't surprising since mixing environment managers like conda and rez isn't necessarily a good idea). |
JeanChristopheMorinPerso
requested review from
a team
and removed request for
Jawabiscuit
|
Considering that this is only affecting the CI, I'll go ahead and merge with a single approval. |
JeanChristopheMorinPerso
merged commit 2c7c50d
into
AcademySoftwareFoundation:master
Fixes #1502
This PR fixes the issues with Python 2.7 in CI. We now use conda to get and install Python 2.7. This is because GitHub decided that it was alright to completely delete their Python 2.7 interpreters from the internet and break the entire world. The funny thing is that they still compile and ship 3.1 and up 🤷.
Note that the csh tests are failing for some reasons. I'm really not sure why. I'm tempted to say that we could ditch csh entirely...Oh, and I also updated our actions to use more recent versions.