Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom package orderer and fixed package orderer sort logic #1680

Conversation

isohedronpipeline
Copy link
Contributor

This carries on the work originally started by @pmolodo with the following PRs:
#355
#413

This change primarily fixes the issue with package orderers not applying to variants, but also adds a new CustomPackageOrder that can be used to configure a specific ranked list of versions.

@isohedronpipeline isohedronpipeline requested a review from a team as a code owner March 7, 2024 23:04
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 91.69329% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 58.67%. Comparing base (153bd87) to head (bbaf290).
Report is 1 commits behind head on main.

❗ Current head bbaf290 differs from pull request most recent head 3a2e3db. Consider uploading reports for the commit 3a2e3db to get more accurate results

Files Patch % Lines
src/rez/package_order.py 91.44% 14 Missing and 9 partials ⚠️
src/rez/utils/yaml.py 75.00% 2 Missing ⚠️
src/rez/cli/config.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1680      +/-   ##
==========================================
+ Coverage   58.03%   58.67%   +0.63%     
==========================================
  Files         127      127              
  Lines       17069    17240     +171     
  Branches     3496     3528      +32     
==========================================
+ Hits         9906    10115     +209     
+ Misses       6496     6459      -37     
+ Partials      667      666       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ben Andersen <[email protected]>
@isohedronpipeline
Copy link
Contributor Author

Closed in lieu of #1684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant