remove evmchai from bodhi exports #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunjizhan
changed the title
xlc
approved these changes
Aug 20, 2024
zjb0807
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
evmchai was only used for waffle testing, and should not be exported by bodhi. So moved it to
waffle/This is a temp workaround, and in the future we can switch to vitest, then remove evmchai plugin completely
close #764
Test
waffle tests all passed.
Not sure why getting bunch of
ECONRESETerror for other tests, doesn't seem bo be related to this change. Probably github CI env glitch