document user_config_dir in README #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrybiddle
suggested changes
Aug 25, 2020
| @@ -61,6 +61,8 @@ On macOS:: | |||
| '/Users/trentm/Library/Caches/SuperApp' | |||
| >>> user_log_dir(appname, appauthor) | |||
| '/Users/trentm/Library/Logs/SuperApp' | |||
| >>> user_config_dir(appname) | |||
| '/Library/Preferences/SuperApp' | |||
There was a problem hiding this comment.
Suggested change
| '/Library/Preferences/SuperApp' | |
| '/Users/trentm/Library/Application Support/SuperApp' |
| @@ -61,6 +61,8 @@ On macOS:: | |||
| '/Users/trentm/Library/Caches/SuperApp' | |||
| >>> user_log_dir(appname, appauthor) | |||
| '/Users/trentm/Library/Logs/SuperApp' | |||
| >>> user_config_dir(appname) | |||
There was a problem hiding this comment.
Suggested change
| >>> user_config_dir(appname) | |
| >>> user_config_dir(appname, appauthor) |
|
Awesome. I can't test the Windows ones but they look good to me (the code mentions they will be the same as the data dir). I can however correct the Mac ones. |
|
@harrybiddle I was confused by your observed behavior, so I looked into it a bit more and it turns out that OSX has changed since the last release 😖 I believe that my original path is actually correct for current master! I guess we're gonna need a maintainer to figure this out for us... @zoofood are you the current maintainer? 🤔 |
|
Oh, dear :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #149
https://github.com/ActiveState/appdirs/blob/master/appdirs.py#L186-L189