Edges Chantelle MediaRanker_Revisited #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from_github(auth_hash) method
…/application.html.erb
…ng wasn't applying and added an image_url column to user
…nly change works they are associated with and altered corresponding controller test, midration, model method, and yaml files
MediaRanker RevistedWhat We're Looking For
|
|
|
||
| redirect_to root_path | ||
| end | ||
| end |
There was a problem hiding this comment.
You redirect but don't return here, and then redirect again on line 40. This is a bug, and will cause Rails to throw an error! Your test coverage probably should have caught this...
| def require_login | ||
| unless session[:user_id] | ||
|
|
||
| flash[:error] = "You must be logged in to do that." |
There was a problem hiding this comment.
I like that this is a controller filter, but you've got much the same code both here and in the users controller. Could you DRY it up further by putting this in the application controller?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.