Jacquelyn Cheng - MediaRanker Revisited #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completed controller tests for users controller and works controller - except upvote action
…g development gem to Gemfile
Added upvote and sessions controller tests
Added OAuth login feature
Modified controller and model tests to account for OAuth
…in Works controller
…tments, created model tests and controller tests for this
Google oauth
MediaRanker RevistedWhat We're Looking For
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I appear to have broken two tests when I added Google OAuth and have not been able to fix them. Specifically seems to be the scenario when logging in for the first time as new user. Issue is confined to the tests, it works on localhost. Please see the second to last commit for a fully functioning test suite -- just wanted to include the final one that does have Google OAuth.