Layla - Edges - MediaRanker Revisited #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droberts-sea
reviewed
Nov 5, 2018
| @@ -2,12 +2,21 @@ class ApplicationController < ActionController::Base | |||
| protect_from_forgery with: :exception | |||
|
|
|||
| before_action :find_user | |||
| # before_action :require_login | |||
|
|
|||
There was a problem hiding this comment.
I love the idea of requiring login as a controller filter, but you've commented this line out!
Remember, you can disable this filter for specific actions using skip_before_action.
|
|
||
| it "can successfully log in with github as an existing merchant" do | ||
| # Arrange | ||
| # make sure that for some existing merchant, everything is configured! |
MediaRanker RevistedWhat We're Looking For
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.