Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semret Nicodimos - Edges - MediaRevisted #33

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Semret Nicodimos - Edges - MediaRevisted #33

wants to merge 7 commits into from

Conversation

snicodimos
Copy link

No description provided.

@droberts-sea
Copy link

MediaRanker Revisted

What We're Looking For

Feature Feedback
General
Appropriate Tests on WorksController These are broken! Now that you've added authorization rules, these tests need to log in before doing the action they're interested in.
Appropriate Tests on SessionsController yes
Appropriate Tests on UsersController no
Completed OAuth yes
Basic Authorization (who can see what) yes
Overall Good work overall. Make sure you review testing around authentication and authorization - this isn't something we'll cover further in class, but the concepts (especially mocking) are very useful in the real world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snicodimos @droberts-sea