Katricia - Edges - Media Ranker Revisited #34

krsmith7 · 2018-10-30T15:46:38Z

No description provided.

…thod that uses OAuth

droberts-sea · 2018-11-05T17:13:14Z

MediaRanker Revisted

Feature	Feedback
General
Appropriate Tests on WorksController	yes
Appropriate Tests on SessionsController	no
Appropriate Tests on UsersController	no
Completed OAuth	yes
Basic Authorization (who can see what)	no
Overall	This is a good start. Make sure you review testing around authentication and authorization - this isn't something we'll cover further in class, but the concepts (especially mocking) are very useful in the real world.

krsmith7 added 23 commits October 15, 2018 19:24

Create and migrate database. Controller test for works#root

5e5ad10

Add works controller tests for index, new, and create

5b731a4

Add OAuth gems

3a297ad

Add config initializer file for authorization

0f40395

Migrate to add columns for github auth

f2a7247

Comment out old login method in sessions. Make new sessions#create me…

30e5623

…thod that uses OAuth

Add user model self method add_user_from_github

b3fd9e7

Edit flash messages. Uncomment logout method

af91183

Edit login link on app view to Login with Github

5a4ffa5

Uncomment sessions#logout route

9730b3c

Edit auth_hash uid in user model

076567a

Edit model tests and fixtures to mirror OAuth user requirements

7695011

Fix typo in sessions controller flash success

4bd007e

Add tests for works_controller show action

a11f184

Correct typo in works controller update action

e71a258

Add tests for works_controller update action

5b4a6f2

Adds test for works controller destroy action

6ca945f

Add first test for works controller upvote action

fbb7586

Delete Logged in as button in app layout page

775f735

Add route helper to sessions create path

fe6f5c9

delete unused debugging statements

42f6c8f

Add to upvote works controller test. 1 failure

4278334

Edit test login path calls for upvote works controller

efb9f40