Christina MedRanRev #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MediaRanker RevistedWhat We're Looking For
|
CheezItMan
reviewed
Oct 31, 2018
| @@ -1,34 +1,59 @@ | |||
| class SessionsController < ApplicationController | |||
| def login_form | |||
| end | |||
| def create | |||
There was a problem hiding this comment.
You don't seem to be setting session[:user_id] = user.id here?
|
|
||
| end | ||
| expect{ | ||
| post upvote_path(id)}.wont_change 'Vote.count' |
|
|
||
| end | ||
| it "redirects to the work page after the user has logged out" do |
|
|
||
| it "redirects to the work page if the user has already voted for that work" do | ||
| it "succeeds for a logged-in user and a fresh user-vote pair" do |
| @@ -1,5 +1,40 @@ | |||
| require "test_helper" | |||
|
|
|||
| describe SessionsController do | |||
| def create | |||
There was a problem hiding this comment.
Why do you have methods here? This is the test file. You should have it blocks and expectations.
I do not understand what's going on here.
| end | ||
|
|
||
| it "redirects to the work page if the user has already voted for that work" do | ||
| user = users(:grace) |
There was a problem hiding this comment.
This is a pretty good attempt at trying to test the login functionality along with voting.
Problems: 1. Your sessions controller isn't setting sessions[:user_id]
2. Somehow the post upvote_path(id) is clearing session completely erasing everything in it. I'm not sure how.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests are passing but I haven't run simplecov yet. I don't think the user is being logged in. Will keep working at it to find it.