Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jackie's MediaRanker Oauth and tests #42

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Jackie's MediaRanker Oauth and tests #42

wants to merge 11 commits into from

Conversation

jfahmy
Copy link

@jfahmy jfahmy commented Oct 30, 2018

No description provided.

@CheezItMan
Copy link

MediaRanker Revisted

What We're Looking For

Feature Feedback
General
Appropriate Tests on WorksController Check
Appropriate Tests on SessionsController Check
Appropriate Tests on UsersController Check
Completed OAuth Well done
Overall Nice work, I like how you used let blocks to log in users getting around the issue with before blocks. You hit all the learning goals, great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfahmy @CheezItMan