apologies for the late submit #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MediaRanker RevistedWhat We're Looking For
|
dHelmgren
reviewed
Nov 7, 2018
| # Tell OmniAuth to use this user's info when it sees | ||
| # an auth callback from github | ||
| # call test helper method mock_auth | ||
| OmniAuth.config.mock_auth[:github] = OmniAuth::AuthHash.new(mock_auth_hash(user)) |
There was a problem hiding this comment.
So your befores weren't working because of a bug in Mini-Test, but here is where I would instead be calling perform_login.
Since before is broken, the best way to fix is to use let instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lingering concerns: I was unable to get omniauth mock to work with a before do block so I called a login before every 'require login' test. This defies all intentions to keep it DRY :(. On many tests I kept getting an error that expected :success but actual response was :found. I changed those specific tests to found but I really don't understand why some of the tests passed with success while others didn't. Lastly, I also had trouble when specifying redirect paths in the test. Even though actions on localhost were performing as expected. For those I changed test expectation to a more generic: 'must respond with redirect'. Any input/advice on the above is appreciated!