Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adagrams #11

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Adagrams #11

wants to merge 23 commits into from

Conversation

marshi23
Copy link

Adagrams

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
What are the components that make up a method? A method opens with a "def" followed by the signature which includes the name of the method and an argument if applicable. Then a code block containing the instruction to be performed by the method. The method definition is closed with an "end".
What are the advantages of using git when collaboratively working on one code base? Allows collaborators to work on the same code at the same time on separate machines. Tracks the history of changes and makes it easier for collaborators to go back, make changes, merge changes, understand the code etc.
What kind of relationship did you and your pair have with the unit tests? A love hate relationship. The unit tests made it easier to rake and see if we were having problems. But it was harder to understand why errors or failures were happening as opposed to running the program directly and spotting the problem. We're still learning how to use them and make our own.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? They made our code shorter and faster to execute. We used 'any?' and 'select' to find ties and select winning words, 'max_by' to find the maximum score & 'map' to create the letter bag array from the letter hash.
What was one method you and your pair used to debug code? Rake, verbally walking through what our code does, trial and error, asking for help.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? Agreed to respect each other and discussed our learning styles on day 1 and we were cool after that.

@marshi23 marshi23 closed this Aug 17, 2018
@marshi23 marshi23 reopened this Aug 17, 2018
@CheezItMan
Copy link

Adagrams

What We're Looking For

Feature Feedback
General
Answered comprehension questions Check, I hope you get more love and less hate in the unit test relationship.
Both teammates contributed to the codebase I assume so
Small commits with meaningful commit messages Granular commits and mostly good commit messages, don't reference waves in the commit messages, just describe the functionality added.
Code Requirements
draw_letters method Nicely done!
Uses appropriate data structure to store the letter distribution Well done!
All tests for draw_letters pass Check
uses_available_letters? method Check, well done
All tests for uses_available_letters? pass Check
score_word method Check
Uses appropriate data structure to store the letter scores Check
All tests for score_word pass Check
highest_score_from method nicely done, well written!
Appropriately handles edge cases for tie-breaking logic Check
All tests for highest_score_from pass Check
Overall Great job! You handled all edge cases nicely. Really great code!

"Z" => 1
}

# create array with all available letters

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Very Nice!


# finds and prints winner 10 letter words auto win, else shortest word wins
winning_hash = {}
winning_word = tied_words.select { |word| word.length == 10 }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nicely written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants