Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved repo over #45

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

moved repo over #45

wants to merge 13 commits into from

Conversation

KatherineJF
Copy link

@KatherineJF KatherineJF commented Nov 6, 2018

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How did you go about exploring the Edamam API, and how did you try querying the API? Read API documentation and used Postman to query the structure of the response data.
What is an API Wrapper? Why is it in lib? How would your project change if you needed to interact with more than one API (aka more than just the Edamam API)? An API allows us to connect with external resources in this instance a database with a repository of recipes. If there were multiple API's I would have multiple classes and class instance variables along with wrapper files to parse them. API is in the lib folder because it isn't a model or controller.
Describe your API wrapper, the methods you created in it, and why you decided to create those methods/how they were helpful Created index and show methods to list all recipes then display specific recipe requirements.
What was an edge case or failure case test you wrote for your API Wrapper? What was a nominal case? Edge case would be empty query data and nominal case would be show recipe details
How does VCR aid in testing an API? Replay responses from the API to reduce the amount of calls you make to it thus saving you money.
What is the Heroku URL of your deployed application? https://young-inlet-31502.herokuapp.com/ . Chris solved my git problem by creating a new git repository and copying my application files to a new dir on my local machine.

@dHelmgren
Copy link

API Muncher

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good
Comprehension questions Good
General
Rails fundamentals (RESTful routing, use of named paths) yes
Semantic HTML Yeah!
Errors are reported to the user Not really, see comments.
API Wrapper to handle the API requests yes
Controller testing Could be more robust, see comments
Lib testing Incomplete
Search Functionality Yes
List Functionality Yes, but it has weird behaviour when I'm mean to it, see comments
Show individual item functionality Yes, see comments in controller
Styling
List view shows 10 items at a time and/or has pagination Yes
Attractive and usable UI Mostly. I have 2 complaints here: 1) the show page has a lot of UI overlapping in an ugly way, and 2) your page links for the index pages are visually cramped. Don't forget to add spaces after the numbers when you generate using ERB!
API Features
The App attributes Edamam No! This is really important! When you're designing code for money, using someone else's work without attribution is a good way to end up in legal trouble.
The VCR cassettes do not contain the API key They do! :(
External Resources
Link to deployed app on Heroku Yes
Overall This submission is on the right track, but there are some holes in it. The best way to describe it is that the User Layer is generally good, but the Programmer Layer is fairly incomplete. Most important things: Don't post app keys, attribute properly, and make sure you do data validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants