Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspiration-board jessie #26

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jessiezhang2017
Copy link

@jessiezhang2017 jessiezhang2017 commented Dec 17, 2018

Inspiration Board

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Explain the steps in creating a new Card from the form. user enters text and emoji on the newCardForm, onFormChange function was called, it updates the text and emoji value on this.state . Then, user click the submit button, it called this.onSubmit function, which check if the text is blank, if not, it calls the addCardCallback function which was passed to newCardForm by board component as a prop, using the text and emoji value entered by user as parameter of the function. addCardCallback on board component will call addCard function , which has an axios post request linked to the heroku url to create a new card in external API database, at the same time, it add the new card to the card list, the state of board is reset to include the new card, which will in turn show the new card on the board.
How did you learn how to use the API? read the API introduction , and tried to use the API on postman
What function did you use to place the GET request from the API to get the list of cards? Why use that function? componentDidMount function. We need to make sure before we use APIs , we have loaded the app and it's data efficiently.
Explain the purpose of a Snapshot test. the purpose of the a snapshot test is to compare future runs of the test to that snapshot and alert the user to any changes.
What purpose does Enzyme serve in testing a React app? Enzyme is a JavaScript Testing utility for React that makes it easier to assert, manipulate, and traverse the React Components’ output.

@CheezItMan
Copy link

Inspiration Board

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commits and good commit messages
Comprehension questions Check
General
Card Component renders the data provided as props Check
Board Component takes a URL and renders the list of Cards and passes in callback functions Check
NewCardform Component is a controlled form and uses a callback function to return entered data to the parent component Check
API
GET request made in componentDidMount Check
DELETE request made in callback function Check
POST request made in callback function passed to NewCardForm component. Check
Snapshot testing Check
Styling Check, well done
Overall Nice work, you hit all the major learning goals of the project.

<div>
Board
<section>
{ this.state.errorMessage}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you're displaying an error message, might be better to give more details (validation errors etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants