Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layla - Edges - Inspiration Board #27

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

lbristol88
Copy link

Inspiration Board

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Explain the steps in creating a new Card from the form. User fills out form and hits submit. This triggers the callback function allowing the new card to display on the board via the post request to the api using axios.
How did you learn how to use the API? I read the documentation and practiced using postman to make requests.
What function did you use to place the GET request from the API to get the list of cards? Why use that function? Using the componentDidMount() function to load all the cards from the API because it is automatically called for you.
Explain the purpose of a Snapshot test. Snapshot testing allows you to detect when your component changes.
What purpose does Enzyme serve in testing a React app? Enzyme is a library that provides more convenient testing syntax, as well as some advanced functionality

@tildeee
Copy link

tildeee commented Dec 21, 2018

Inspiration Board

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
General
Card Component renders the data provided as props x
Board Component takes a URL and renders the list of Cards and passes in callback functions x
NewCardform Component is a controlled form and uses a callback function to return entered data to the parent component x
API
GET request made in componentDidMount x
DELETE request made in callback function x
POST request made in callback function passed to NewCardForm component. x
Snapshot testing one of the tests fail?
Styling x
Overall

Hi Layla!

Great work on this project.

One major thing -- there's a syntax error on your package.json, so basically I can't run npm install with your project as it's submitted. I'm making a more specific comment on this. Mostly this affects how I grade this because I can't run your project as is

Also, two small things ;)

  • it would have been nice if the new card form had a drop down for allowed emoji.
  • was there a requirement to make both text and emoji required? That being said, nice job on the user feedback.

Other than that, the code looks great. Good work on this project!


"jest": {
"snapshotSerializers": ["enzyme-to-json/serializer"]
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You made the jest section outside of the big object here, when really it needs to be a sibling to homepage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants