Personal-Profile Katherine Fitzpatrick

[KatherineJF]

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	Validator found tags that weren't closed which I resolved by closing or deleting tags.
Why is it important to consider and use semantic HTML?	Provides a guide of page content used when the contents of the page are read aloud.
How did you decide to structure your CSS?	Main styles.css with cascading styles for individual pages. Inherited styles were overwritten by local .css as needed.
What was the most challenging piece of this assignment?	Figuring out how to manage multiple style sheets and layout was time consuming.
Describe one area that you gained more clarity on when completing this assignment	Layout using flex and grid and style sheets.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

[CheezItMan]

Personal Portfolio Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	Reasonable number of commits and mostly good commit messages, some like format editist don't make much sense.
Answered comprehension questions	Check, I'm glad you gained more clarity on multiple stylesheets and flex & grid.
Page fully loads	Check
No broken links (regular or images)	Check
Includes at least 4 pages and styling	Check
HTML
Uses the high-level tags for organization: header, footer, main	You should use more high-level sectioning tags which provide semantic meaning rather than using div elements with classes for the semantic meaning.
Appropriately using semantic tags: section, article, etc.	You do overuse div a bit instead of using semantic section elements.
All images include alternate text	Missing some alt attributes
CSS
Using class and ID names in style declarations	Effective use of ids and classes
Style declarations are DRY	Relatively DRY css content
Overall	You do have some errors in your HTML content, and you should use more semantic HTML instead of div elements. I do love the media queries which adjust one page's layout for smaller screens. I also like how you made good use of grid and flex for the page layouts. Overall you hit the major learning goals of the project. Well done.

[CheezItMan]

normalize is not a relationship, that should be stylesheet

[CheezItMan]

The list items here are broken

[CheezItMan]

misspelled body element

[CheezItMan]

Why not use a header element?

[CheezItMan]

Why not use a main element?

[CheezItMan]

Better to use a main element

[CheezItMan]

missing alt attributes

[CheezItMan]

Making the target="_blank" for the links forces each link to open in a separate tag. Some people, myself included find this annoying.