Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edges Chantelle Personal Portfolio Site #32

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

BASIC-Belic
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? No
Why is it important to consider and use semantic HTML? It makes it easier to read esp if yor page does't render how you think it should.
How did you decide to structure your CSS? I used a lot of flex boxes within grids.
What was the most challenging piece of this assignment? Alignment, sticking to and choosing a design, CSS in general.
Describe one area that you gained more clarity on when completing this assignment Using grid and layout stuff.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

@tildeee
Copy link

tildeee commented Sep 30, 2018

For this project, the instructors are giving a spot-check review. If you’d like a more in-depth review, please reach out to your instructor!

My review:
Chantelle, great work! Hahaha, I looove the placeholder text. Anyway, the site meets all of the project requirements, and it looks good too. You have some placeholder images on the bottom of your hobby blog page, and so they are broken images... I'd rather you take those out before submission!

Great work otherwise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants