maryams portfolio

[marshi23]

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	Yes, I missed a few closing tags, and also needed to add alt text.
Why is it important to consider and use semantic HTML?	It makes the code and html page easier to understand, it also informs the browser on html and it makes selecting css selectors easier.
How did you decide to structure your CSS?	I mainly used flex box.
What was the most challenging piece of this assignment?	Aligning the page element in the positions I want them to be in was challenging.
Describe one area that you gained more clarity on when completing this assignment	Definalty the use of flex and using images.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

[CheezItMan]

Personal Portfolio Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	Good number of commits and good commit messages
Answered comprehension questions	Check
Page fully loads	Check
No broken links (regular or images)	Check
Includes at least 4 pages and styling	Check
HTML
Uses the high-level tags for organization: header, footer, main	Check
Appropriately using semantic tags: section, article, etc.	Check
All images include alternate text	Check
CSS
Using class and ID names in style declarations	Lots of effective uses of class declarations
Style declarations are DRY	Relatively DRY style declarations
Overall	Well done, you hit all the learning goals for the project. The site works as required. The pages shrink to the size of the device, which can make things hard to see. Just something to notice for future sites and not something we've taught you how to deal with.

[CheezItMan]

Indentation is a little off and you have an unclosed section element