Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amber Lynn - Edges - Personal Portfolio Site #39

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

griffifam
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Yes, but small things dealing with empty content and spacing around the footer copyright character
Why is it important to consider and use semantic HTML? Organizational and sometimes indicates how something will render;
How did you decide to structure your CSS? Largely in grids and a little in flexbox. I wanted to showcase a picture on almost every page which I almost achieved except on my portfolio page - the most stoic and static page of them all, in my opinion.
What was the most challenging piece of this assignment? How to develop a scrollbar for my about page and journal. I purposefully added less content because I couldn't get scroll to work.
Describe one area that you gained more clarity on when completing this assignment My links were not hovering because I had an extra div container that wasn't really doing anything that stood in the way of it working
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? NO.
Overall

@tildeee
Copy link

tildeee commented Sep 30, 2018

For this project, the instructors are giving a spot-check review. If you’d like a more in-depth review, please reach out to your instructor!

My review:
It looks great! It hits all of the requirements, the site looks great, and I loooove the content. In your about page, you end up using divs way more than usual compared to your other pages. Otherwise, wonderful job. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants