Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naheed- Edges- Personal Portfolio #44

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

arangn
Copy link

@arangn arangn commented Sep 19, 2018

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? It caught a few stray tags in my documents
Why is it important to consider and use semantic HTML? To improve readability and accessibility
How did you decide to structure your CSS? I had a lot of trouble formatting my pages, and ended up using simple grids to format my sections
What was the most challenging piece of this assignment? This was very challenging for me because I ran into a lot of trouble with my css- I wasn't sure why some things weren't being implemented, and I also had trouble putting things in the right place in my grid
Describe one area that you gained more clarity on when completing this assignment EVERYTHING, I learned a lot doing this project, I now have a much better sense of how to create the layout of my page
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

@droberts-sea
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage yes
Answered comprehension questions yes
Page fully loads yes
No broken links (regular or images) direct links to projects didn't work for me, but everything else looks good
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main yes
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text yes
CSS
Using class and ID names in style declarations yes
Style declarations are DRY I see some repeated styles page-to-page. One way to address this is to break your CSS out into multiple files: main.css, which contains the styles applied to every page (like the header and nav), and a stylesheet for each individual page containing specific styles for that page.
Overall

Good work overall! It's clear to me that the learning goals for this assignment were met.

For this project, the instructors are giving a spot-check review, looking for big patterns rather than going through your code line-by-line. If you’d like a more in-depth review, please reach out to your instructor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants