Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sammi-Jo's site [is under construction!] [nodes] #46

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sjlee3157
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?
Why is it important to consider and use semantic HTML?
How did you decide to structure your CSS?
What was the most challenging piece of this assignment?
Describe one area that you gained more clarity on when completing this assignment
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?

@CheezItMan
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage Only a few commits, but only part of one page done.
Answered comprehension questions Nope
Page fully loads Nope
No broken links (regular or images) Check
Includes at least 4 pages and styling Only one page
HTML
Uses the high-level tags for organization: header, footer, main Check, on the one page
Appropriately using semantic tags: section, article, etc. Check
All images include alternate text Check, but you misspelled the img tag.
CSS
Using class and ID names in style declarations Good use of classes
Style declarations are DRY Still fairly dry given the small state of the site
Overall It's a start. As you noted you were otherwise occupied last weekend. See my inline note, but it's a basic start to things.

<header class="header">
<h1>Sammi-Jo Lee</h1>
<sub>This is what a developer looks like.</sub>
<p><image src="http://via.placeholder.com/400x200" class="mobileHide portraitHide landscapeShow desktopShow" alt="Sammi-Jo Lee name and logo" /></p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tag name is img

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants