Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addy & lindsay - edges - video store #20

Open
wants to merge 75 commits into
base: master
Choose a base branch
from

Conversation

elle-terch
Copy link

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C10/VideoStoreConsumer-API#20
For each person in your pair, describe something you learned from your partner during this project Addy: lindsay sent research for react router Lindsay: some really amazing CSS tricks (gradients!) & how to better use ternaries rather than if/else statements Both: how to pass things between components
What was one area of React you gained more clarity on during this assignment? Why the React router is much more efficient than going to different pages.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We let the parent build the child components and passed in specifics about what things needed to look like.
Describe how you handled rentals with React When you click on a movie to select it, it passes props to the parent, App, which maintains it in state until the button is clicked to check out (then it will make the axios call using the state).
Describe a DOM event your application handled Routing
Did you use any functional stateless components? What for? Most of our components were stateless. Movie, customer, status bar and nav bar were all functional components because we only cared about those storing appearance.
Did you use any container components? What for? We used containers for search results, customer list and library list.
Do you have any recommendations on how we could improve this project for the next cohort?

addisoncole and others added 30 commits December 17, 2018 16:13
…nent. App.js now passes dprops to New Rental component, which is made up on selectors which take in props of the type of selector being used and the current selected element.
…bar component that is ffunctional, insofar as it returns its form input to the console.
…it queries rails api for search term and populates the search section with movies in the component's state array.
elle-terch and others added 30 commits December 19, 2018 20:31
… return movie components. button for movie component is now modular, and will take a proptype to name it.
…anged styling for New rental component to take this into account. styling on selectors changed font weight. add transition animation to customer component.
… currently selected and will stay red if navigated away from or back to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants