Pr-2 #2

CheezItMan · 2019-08-12T23:58:21Z

This method calculates a factorial

Faiza1987 · 2019-08-15T20:57:23Z

function.rb

@@ -0,0 +1,9 @@
+
+def function(n)
+  if n == 0


Function has no name

I agree this function needs to have a name, just as a reminder functions have:

name > the function name.

param > the name of an argument to be passed to the function. Maximum number of arguments varies in different
engines.

statements> the statements which comprise the body of the function

cyndilopez · 2019-08-15T20:58:07Z

function.rb

+  else
+    n * function(n-1)
+  end
+end


What is being returned?

Just to add , by default, functions return undefined. To return any other value, the function must have a return statement that specifies the value to return.

cyndilopez · 2019-08-15T20:58:19Z

function.rb

+
+def function(n)
+  if n == 0
+    1


assign to variable

Faiza1987 · 2019-08-15T20:58:21Z

function.rb

+def function(n)
+  if n == 0
+    1
+  else


should specify if you are returning 1 or what is happening with 1

cyndilopez · 2019-08-15T20:58:31Z

function.rb

+  if n == 0
+    1
+  else
+    n * function(n-1)


assign to variable

cyndilopez

needs work

carlabosco · 2019-08-15T20:59:57Z

function.rb

@@ -0,0 +1,9 @@
+
+def function(n)


Should we use more descriptive names for "function" and "n" here?

griffifam

function name change

griffifam · 2019-08-15T21:00:56Z

function.rb

@@ -0,0 +1,9 @@
+
+def function(n)


Change function to a name that tells what method does.

MariaWissler

Lets double check this code, let us know once you submit your updates

MariaWissler · 2019-08-15T21:05:08Z

function.rb

@@ -0,0 +1,9 @@
+
+def function(n)
+  if n == 0


I agree this function needs to have a name, just as a reminder functions have:

name > the function name.

param > the name of an argument to be passed to the function. Maximum number of arguments varies in different
engines.

statements> the statements which comprise the body of the function

MariaWissler · 2019-08-15T21:07:48Z

function.rb

+  else
+    n * function(n-1)
+  end
+end


Just to add , by default, functions return undefined. To return any other value, the function must have a return statement that specifies the value to return.

jessicacaley · 2019-08-15T20:58:29Z

function.rb

@@ -0,0 +1,9 @@
+
+def function(n)
+  if n == 0


This function is pretty short. Have you considered using a ternary?

jessicacaley · 2019-08-15T21:00:40Z

function.rb

@@ -0,0 +1,9 @@
+
+def function(n)
+  if n == 0


Suggested change

if n == 0

n == 0 ? 1 : n * function(n-1)

AngelaOh · 2019-08-15T20:58:15Z

function.rb

+
+def function(n)
+  if n == 0
+    1


We will likely want a return statement here.

AngelaOh · 2019-08-15T21:00:29Z

function.rb

+  if n == 0
+    1
+  else
+    n * function(n-1)


Suggested change

n * function(n-1)

return n * function(n-1)

Faiza1987 · 2019-08-15T21:00:06Z

function.rb

+    1
+  else
+    n * function(n-1)
+  end


Does the new value of n need to be available outside of the function? It should be saved in a variable and returned.

piffer59 · 2019-08-15T20:58:47Z

function.rb

@@ -0,0 +1,9 @@
+
+def function(n)


method should have a more descriptive name

Kimberly-Fasbender · 2019-08-15T20:58:56Z

function.rb

@@ -0,0 +1,9 @@
+
+def function(n)


Could we rename this function? Maybe we could name it factorial?

Kimberly-Fasbender · 2019-08-15T21:03:51Z

function.rb

@@ -0,0 +1,9 @@
+
+def function(n)
+  if n == 0


Do we want to change this to a ternary?

function method added

1ecb4a0

CheezItMan changed the title ~~function method added~~ Pr-2 Aug 13, 2019

Faiza1987 reviewed Aug 15, 2019

View reviewed changes

cyndilopez reviewed Aug 15, 2019

View reviewed changes

function.rb

def function(n)

if n == 0

1

Copy link

cyndilopez Aug 15, 2019 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assign to variable

Faiza1987 reviewed Aug 15, 2019

View reviewed changes

function.rb

def function(n)

if n == 0

1

else

Copy link

Faiza1987 Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should specify if you are returning 1 or what is happening with 1

cyndilopez reviewed Aug 15, 2019

View reviewed changes

function.rb

if n == 0

1

else

n * function(n-1)

Copy link

cyndilopez Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assign to variable

cyndilopez reviewed Aug 15, 2019

View reviewed changes

carlabosco reviewed Aug 15, 2019

View reviewed changes

function.rb

@@ -0,0 +1,9 @@

def function(n)

Copy link

carlabosco Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use more descriptive names for "function" and "n" here?

griffifam reviewed Aug 15, 2019

View reviewed changes

function.rb

@@ -0,0 +1,9 @@

def function(n)

Copy link

griffifam Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change function to a name that tells what method does.

MariaWissler suggested changes Aug 15, 2019

View reviewed changes

jessicacaley reviewed Aug 15, 2019

View reviewed changes

AngelaOh reviewed Aug 15, 2019

View reviewed changes

Faiza1987 reviewed Aug 15, 2019

View reviewed changes

piffer59 reviewed Aug 15, 2019

View reviewed changes

function.rb

@@ -0,0 +1,9 @@

def function(n)

Copy link

piffer59 Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

method should have a more descriptive name

Kimberly-Fasbender suggested changes Aug 15, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pr-2 #2

Pr-2 #2

CheezItMan commented Aug 12, 2019

Faiza1987 Aug 15, 2019

MariaWissler Aug 15, 2019

cyndilopez Aug 15, 2019

MariaWissler Aug 15, 2019

cyndilopez Aug 15, 2019 •

edited

Loading

Faiza1987 Aug 15, 2019

cyndilopez Aug 15, 2019

cyndilopez left a comment

carlabosco Aug 15, 2019

griffifam left a comment

griffifam Aug 15, 2019

MariaWissler left a comment

MariaWissler Aug 15, 2019

MariaWissler Aug 15, 2019

jessicacaley Aug 15, 2019

jessicacaley Aug 15, 2019

AngelaOh Aug 15, 2019

AngelaOh Aug 15, 2019

Faiza1987 Aug 15, 2019

piffer59 Aug 15, 2019

Kimberly-Fasbender Aug 15, 2019

Kimberly-Fasbender Aug 15, 2019

Pr-2 #2

Are you sure you want to change the base?

Pr-2 #2

Conversation

CheezItMan commented Aug 12, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cyndilopez Aug 15, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cyndilopez left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

griffifam left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MariaWissler left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cyndilopez Aug 15, 2019 •

edited

Loading