Pr 5 #5
Pr 5 #5
Conversation
| }); | ||
| }); | ||
|
|
||
| return isAllUnique; |
There was a problem hiding this comment.
this will return true when the array is empty
| }); | ||
| }); | ||
|
|
||
| return isAllUnique; |
There was a problem hiding this comment.
Good job writing this algorithm. This would run but there might be way to find whether all elements in an array is unique a little more efficient by switching the isAllUnique to false when you find a duplicated value and end the iteration there instead of iterated through all elements of the array
| let isAllUnique = true; | ||
|
|
||
| array.forEach((currentElement, currentIndex) => { | ||
| array.slice(currentIndex + 1).forEach((elementToCompare) => { |
There was a problem hiding this comment.
This seems a little complicated - consider removing the slice method entirely and just compare to the current element.
|
|
||
| array.forEach((currentElement, currentIndex) => { | ||
| array.slice(currentIndex + 1).forEach((elementToCompare) => { | ||
| if (elementToCompare === currentElement) { |
There was a problem hiding this comment.
I'm not sure why we need to slice here. Can we remove it? I think the nested forEach will take care of comparing each element to the outer forEach element.
| let isAllUnique = true; | ||
|
|
||
| array.forEach((currentElement, currentIndex) => { | ||
| array.slice(currentIndex + 1).forEach((elementToCompare) => { |
There was a problem hiding this comment.
This syntax is a little confusing -- does it make more sense to compare currentElement to array[currentIndex + 1] instead of using array.slice(...).forEach(...)?
| @@ -0,0 +1,16 @@ | |||
|
|
|||
| const isAllUniqueElements = (array) => { | |||
| let isAllUnique = true; | |||
There was a problem hiding this comment.
We may want to assign is AllUnique to something else. If the array is empty, it will evaluate to true.
| @@ -0,0 +1,16 @@ | |||
|
|
|||
| const isAllUniqueElements = (array) => { | |||
| let isAllUnique = true; | |||
There was a problem hiding this comment.
Let's check for if the array is empty and return appropriately.
This method determines if each element is unique.