Pr-7 #8
Open
Pr-7 #8
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did you change the name of the PR from "Node class" to "Pr-7"? I'd like to see "Add JavaScript Node class" once this is merged so it's clear. |
kaidamasaki
reviewed
Aug 13, 2019
| while (current != null) { | ||
| console.log(current.value); | ||
| current = current.getNext(); | ||
| } |
There was a problem hiding this comment.
I think I'd prefer to see this build up something like "1 -> 2 -> 3 -> null".
| } | ||
| } | ||
|
|
||
| export default Node; |
AngelaOh
reviewed
Aug 15, 2019
| let current = this; | ||
|
|
||
| while (current != null) { | ||
| console.log(current.value); |
There was a problem hiding this comment.
Does this console.log need to be here?
alexandria7
reviewed
Aug 15, 2019
| printList() { | ||
| let current = this; | ||
|
|
||
| while (current != null) { |
There was a problem hiding this comment.
might be a little cleaner to say "while (current)"
Suggested change
| while (current != null) { | |
| while (current) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.