-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evelynn #12
base: master
Are you sure you want to change the base?
Evelynn #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, you fully applied dynamic programming to these solutions. Well done!
# Time Complexity: ? | ||
# Space Complexity: ? | ||
# Time Complexity: O(n), where n is the number of elements input in the array. | ||
# Space Complexity: O(1) | ||
def max_sub_array(nums) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
elsif num == 1 | ||
return "1" | ||
elsif num == 2 | ||
return "1 1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really need these? If you have the array, do you need these elsif
conditions?
@@ -1,7 +1,26 @@ | |||
# Time complexity: O(n) where n is the input value. | |||
# Space Complexity: O(n) where n is the input value. | |||
def newman_conway(num) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.