Ports - Kasey #28
Open
Ports - Kasey #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ace-n
suggested changes
Apr 29, 2019
| @@ -5,8 +5,18 @@ | |||
| # .... | |||
| # e.g. 6th fibonacci number is 8 | |||
|
|
|||
| # Time complexity: ? | |||
| # Space complexity: ? | |||
| # Time complexity: 0(n), where the program only loops through it n times (well, n - 2 times because the first few things are hardcoded cases), was wondering if it was better to do it with recursion? but that would run it with recursion instead of saving everything in an array and indexing it, but I think that would run more times? | |||
There was a problem hiding this comment.
I kind of get what n is here, but loops through it n times is a bit of a tautology.
Can you explain it more clearly perhaps? e.g. O(n), where n = the number of digits in the input number or O(n), where n = the input number itself.
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: 0(n), where the program only loops through it n times (well, n - 2 times because the first few things are hardcoded cases), was wondering if it was better to do it with recursion? but that would run it with recursion instead of saving everything in an array and indexing it, but I think that would run more times? | ||
| # Space complexity: constant, although you have to initialize space for an array |
There was a problem hiding this comment.
I reckon you can get to constant space though - any ideas on how you'd do it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.