Kate N #26
Open
Kate N #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 3, 2019
There was a problem hiding this comment.
If I can make a suggestion, start with the easier methods, add_first etc and run those tests first and then move to the other methods. It looks like you jumped to things like reverse which are pretty tricky.
It's clear that this was a challenging assignment. I'd like you, if you have time, to schedule time with me or a tutor to look at the CS fun work. I don't want you to get far behind.
| def add_first(value) | ||
| raise NotImplementedError | ||
| node = Node.new data |
| # note: the nodes should be moved and not just the values in the nodes | ||
| # Time Complexity: | ||
| # Space Complexity | ||
| # Space Complexity: | ||
| # do with + w/o recursion ? | ||
| def reverse |
There was a problem hiding this comment.
👍
Since you didn't make any external data structures, your space complexity here is O(1), and since you have to traverse the list once, your time complexity is O(n). You can usually guess this by the fact that there is one and only one loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.