Cyndi #31
Open
Cyndi #31
+587
−340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rformed as part of CS class @ Uber
CheezItMan
reviewed
Sep 2, 2019
| # returns the value at the middle element in the singly linked list | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_middle_value |
There was a problem hiding this comment.
You could also use the previously written get_at_index method.
| visited_nodes = [] | ||
| current = @head | ||
| while !current.nil? | ||
| if visited_nodes.include?(current) |
There was a problem hiding this comment.
Because .include? traverses through visited_nodes, this is another loop! So your time complexity is actually O(n2).
Is there another way to do this without a 2ndary array?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rformed as part of CS class @ Uber