Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ports - Kim #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ports - Kim #15

wants to merge 1 commit into from

Conversation

Kimberly-Fasbender
Copy link

No description provided.

ace-n
ace-n reviewed May 3, 2019
View reviewed changes
Copy link

@ace-n ace-n left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass + analysis LGTM. Nice work! 😄

Edit: I reckon the time complexity on this is better than O(n^3). Any idea why? (Hint: is the zero-setting code within the second block of loops executing for every value in the matrix?)

lib/matrix_convert_to_zero.rb

rows.times do |row|
cols.times do |col|
matrix[row][col] = "x" if matrix[row][col] == 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of temporary state tracking here! 👍

(This technique becomes super-relevant when you start working with things like graphs and trees.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kimberly-Fasbender @ace-n