Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports - Elle and Cloudy #23

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Conversation

dev-elle-up
Copy link

@dev-elle-up dev-elle-up commented Apr 20, 2019

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way We set up models for Passengers, Drivers and Trips. Then we established relationships between Passengers and Trips (one-to-many) and Drivers and Trips (one-to-many). This was the solution that seemed most logical and streamlined to us. It gave us the ability to access and display the properties of the driver associated with the same trip a passenger took, and vice versa.
Describe the role of model validations in your application We require the driver to have a unique vin to ensure there are no duplicate driver instances. A new trip must have a cost so that the display calculations function (can't divide nil by 100!). All other validations are choices on what we thought a trip, driver, and passenger should be required to have.
How did your team break up the work to be done? We mostly worked together on the setup. Then Elle took on finishing the logic and interconnectedness while Cloudy focused on styling.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline? We prioritized getting all of the functionality working and getting all of the views and actions linked together between all three models. In the interest of time, we set aside giving the user valuable error messages when they tried to do something that isn't allowed (such as make a driver without a name)as well as implementing our plan for what to do when a user tries to delete a driver/passenger that has trips (plan: make inactive; actual: ugly error message). We also wanted to make a cancel button on the new and edit pages so that you can abort that action and return to the previous page but time did not allow for this.
What was one thing that your team collectively gained more clarity on after completing this assignment? Git: merging and branches and history and commits. Yay! Also all the parts of Rails and how they work together, including the has_many and belongs_to relationship configurations.
What is your Trello board URL? https://trello.com/b/sbOkpNPP/ride-share-on-rails
What is the Heroku URL of your deployed application? https://e-and-c-rails-ride-share.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We discussed what went well and what our challenges were. We agreed that we worked well together. This was greatly helped by our shared priority goal of learning rather than getting it done. Our communication was great, too. Challenges discussed were mostly around the environment, being interrupted by other people, and not having meaningful time to work on it during the week. We gave each other feedback on some communication points to improve going forward (yay! very helpful). What came up in the peer feedback was not a surprise because we checked in often, discussing our processes and communication styles, and tweaked things throughout the week. For both of us, this was our most successful pair experience thus far.

dev-elle-up and others added 30 commits April 16, 2019 13:31
…ver, Passenger, Trip. Added foreign keys to Trip. Got databases working and seeded locally.
…rivate passenger_params method. Added validation to passenger model - require name and phone num.
…. Also fixed a tiny bug (shh) in passenger model. (Don't tell.)
…on. Integrated links between pages. Started pseudo-coding a home page.


Cloudy updated views. Elle is pulling to see the changes.
…esolve a merge conflict with Cloudy's styling branch. This brings the elle branch up to date with the cloudy branch. Next task will be to merge into master.
Merging the changes Cloudy did on the cloudy branch, which I merged by mistake into the elle branch by doing a git pull while on that branch. Oops. Fixing everything.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants