Niv #19
Open
Niv #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 10, 2019
| @@ -1,7 +1,26 @@ | |||
| require_relative './stack.rb' | |||
|
|
|||
| def balanced(string) | |||
| raise NotImplementedError, "Not implemented yet" | |||
| pairs = {")" => "(", "}" => "{", "]"=>"["} | |||
lib/queue.rb
Outdated
| end | ||
|
|
||
| def enqueue(element) | ||
| raise NotImplementedError, "Not yet implemented" | ||
| @store.push(element) |
There was a problem hiding this comment.
This isn't using a circular buffer, it works, but not what I requested.
lib/queue.rb
Outdated
| end | ||
|
|
||
| def dequeue | ||
| raise NotImplementedError, "Not yet implemented" | ||
| removed = @store[0] | ||
| @store = @store[1..-1] |
There was a problem hiding this comment.
Just a note, dequeue is an O(n) operation because of how you're using the array here.
CheezItMan
reviewed
Sep 17, 2019
| end | ||
|
|
||
| def enqueue(element) | ||
| raise NotImplementedError, "Not yet implemented" | ||
| if @front == 0 && @rear == @BUFFER_SIZE - 1 |
There was a problem hiding this comment.
This could run into trouble if the Queue becomes full and the front is not at index 0.
Consider if you had a buffer size of 10,
You add 9 elements, remove one (so front is at index 1) and then try to add 7 more. What happens?
| end | ||
|
|
||
| def dequeue | ||
| raise NotImplementedError, "Not yet implemented" | ||
| removed_data = @store[@front] |
There was a problem hiding this comment.
Before dequeuing you should check to see if the queue is empty.
| if (@front == @rear) | ||
| @front = -1 | ||
| @rear = -1 | ||
| elsif @front === @BUFFER_SIZE - 1 |
There was a problem hiding this comment.
This kind of elsif statements work or you could do: @front = (@front + 1) % BUFFER_SIZE
| display_store = @store[@front...@rear+1] | ||
| else | ||
| first_half = @store[0...@rear] | ||
| second_half = @store[@[email protected]+1] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation