Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets-Bita-Rosalyn #17

Open
wants to merge 61 commits into
base: master
Choose a base branch
from
Open

Sockets-Bita-Rosalyn #17

wants to merge 61 commits into from

Conversation

Bitaman
Copy link

@Bitaman Bitaman commented Jun 28, 2019

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C11/VideoStoreConsumer-API#12
For each person in your pair, describe something you learned from your partner during this project Bita: I learned a lot about react callbacks from Rosalyn, React is still tricky to me and Rosalyn figured out all our problems with lifting the state by making complicated callback functions./Rosalyn: Bita did a great job figuring out the API aspect of the project and integrating rails to our react app.
What was one area of React you gained more clarity on during this assignment? Bita: designing the components and deciding where to keep data in states, also making callback functions to pass the props./Rosalyn: Passing up state. Better understanding of the relationship between parent and child and how you can pass state down and particularly up from child to the parent.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content we kept them separate by having two different component one for search and one for library.
Describe how you handled rentals with React When a movie and customer is added to checkout in their respective components, it is sent in a callback function to app. App stores them in its state and sets checkout status to true. It then passes them as a prop to to checkout rental component. Checkout component checks for the checkout status as well as the movie and rental passed to it. When all those requirements are fulfilled, the checkout button appears. Once clicked it populates checkout state with the movie and customer, an axios post request is made providing the checkout path with the movie, passing in params of customer id and due date.Customer and movie is also provided in a callback function found in app which keeps track of whether the checkout is complete or not
Describe a DOM event your application handled The Search for movie button has an event handler, in the event handler we made an axios call which made a get request to the movies API end point with adding the name of the movie we wanted to search(coming from another DOM event, changing the input of the text input) and got all the movies that had the name we were searching for and send them to app with a callback function.
Did you use any functional stateless components? What for? We did not but our movie component is a stateless classical component.we could use a functional component but we started all our components as classical and we didn't change it.
Did you use any container components? What for? Yes, we used the react routes components. This was used to render the specified component when the route path matched.
Do you have any recommendations on how we could improve this project for the next cohort? This project was a great starting point to our capstone. There was just enough ambiguity to make it hard but also a challenge to figure out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants