Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erica and Shubha - Sockets #6

Open
wants to merge 57 commits into
base: master
Choose a base branch
from

Conversation

shubha-rajan
Copy link

@shubha-rajan shubha-rajan commented Jun 26, 2019

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C11/VideoStoreConsumer-API#3
For each person in your pair, describe something you learned from your partner during this project Shubha - I learned a lot about working with the React Router and passing props and callbacks into router components. (I also learned to just ask an instructor for help instead of staring at a problem forever and making no progress) Erica - I got a better understanding on props/state and how components are interacting with each other and the best way to communicate between components.
What was one area of React you gained more clarity on during this assignment? Using axios with React.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We utilized a single MovieCard component that both MovieLibrary and Search could use to fill their lists. The difference in what buttons displayed and what select callbacks were used was solved by passing in these things through props.
Describe how you handled rentals with React We used a Selected component to track and display the currently selected movie and customer. The selected component also included a button which, when clicked, sent a POST request to the rentals endpoint which included the selected movie and customer as params.
Describe a DOM event your application handled We had an onChange handler for the search bar, as well as onClick handlers for all of the buttons.
Did you use any functional stateless components? What for? Notification and Customer are both functional stateless components
Did you use any container components? What for? MovieLibrary and CustomerList were both container components. The container components were responsible for making axios requests and rendering the MovieCard and Customer components.
Do you have any recommendations on how we could improve this project for the next cohort? Not really

shubha-rajan and others added 30 commits June 24, 2019 12:08
shubha-rajan and others added 27 commits June 26, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants