Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports - Sav & Angela #9

Open
wants to merge 112 commits into
base: master
Choose a base branch
from
Open

Ports - Sav & Angela #9

wants to merge 112 commits into from

Conversation

AngelaOh
Copy link

@AngelaOh AngelaOh commented Jun 27, 2019

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C11/VideoStoreConsumer-API#6
For each person in your pair, describe something you learned from your partner during this project Angela: I learned how a back-end more concretely fits into a front-end React. Sav: Ditto!
What was one area of React you gained more clarity on during this assignment? Angela: I gained clarity on when re-rendering happens. (when state is changed) Sav: I gained clarity on lifecycle, view logic (hide/display), router.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content. We reused the Movie component.
Describe how you handled rentals with React We held state of selected items in Homepage. Once customer and movie was selected, we displayed the checkout button which triggered a callback function that posted to the API.
Describe a DOM event your application handled See above.
Did you use any functional stateless components? What for? Yes, our movie and customer components.
Did you use any container components? What for? Yes, movie library, movie search, and customer list.
Do you have any recommendations on how we could improve this project for the next cohort? Not at this time, great project!

AngelaOh and others added 30 commits June 24, 2019 14:49
Homepage - Basic routes setup
Refactored Movie Library; Can Select Movie and Display at Top
qqdipps and others added 30 commits June 27, 2019 14:31
Added margins, changed ID to external ID, added modal to display movie information
Prop types double check, ALERT: updated func names
disabled button if movies have already been added
added disabled button for movie selected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants