Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branches - Xinran #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Branches - Xinran #6

wants to merge 1 commit into from

Conversation

gracexinran
Copy link

No description provided.

CheezItMan
CheezItMan reviewed Apr 10, 2020
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work, you made it work with BFS using two queues. I wish you'd taken the chance to demo this in class. It's a neat way to avoid the performance penalty with .unshift, which is what several people did.

Great work.

test/possible_bipartition_test.rb
@@ -86,6 +86,26 @@
expect(answer).must_equal false
end

it "will return false for a graph which cannot be bipartitioned" do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/possible_bipartition.rb
end

def bfs(q1, q2, hash1, hash2, visited, dislikes)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you did BFS with 2 queues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gracexinran @CheezItMan