Branches - Michaela #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Apr 10, 2020
| i += 1 | ||
| end | ||
|
|
||
| until queue.empty? && unchecked_vertices.empty? |
There was a problem hiding this comment.
Nice that you have this loop to make sure you hit all the vertices.
Comment on lines
+49
to
+54
| def remove_first_from_queue(list) | ||
| temp = list[-1] | ||
| list[-1] = list[0] | ||
| list[0] = temp | ||
|
|
||
| return list.pop() |
There was a problem hiding this comment.
Clever way to remove the last from the queue, but remember that now the formerly last element is now the front of the queue.
So like if the queue was:
[3, 5, 27, 15]
After your remove_first_from_queue
[15, 5, 27]
So the next time you remove something from the front of the queue, you'll get 15... which isn't really queue-like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.